-
Notifications
You must be signed in to change notification settings - Fork 14
Daily Reminder #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Daily Reminder #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reverse once stagging testing done]
…inder (Boolean) columns to threads
…e handling Replace explicit SQLAlchemy Column definitions for latest_thread and daily_reminder with typed Field-style annotations (int, bool) and remove the manual recurrence property/setter in favor of the EnumField(Recurrence) definition.
…d.update for updates, remove duplicated daily_reminder handler, avoid fetching channels when no latest_thread, and tidy imports/formatting
PenguinBoi12
requested changes
Oct 19, 2025
Contributor
PenguinBoi12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, only a few things to change but nothing big.
… test for post thread and unload jobs
PenguinBoi12
approved these changes
Oct 19, 2025
Contributor
PenguinBoi12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue solves the PR #141
Demo